Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): remove some explicit fonts #4286

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix(theme): remove some explicit fonts #4286

merged 2 commits into from
Oct 18, 2024

Conversation

Jungzl
Copy link
Contributor

@Jungzl Jungzl commented Oct 15, 2024

Description

These fonts before sans-serif have poor rendering on Windows, remove them so that users who don't have PingFang SC & Noto Sans SC' installed can still set their preferred fonts.
image

Tip

The author of this PR can publish a preview release by commenting /publish below.

@Jungzl
Copy link
Contributor Author

Jungzl commented Oct 17, 2024

/publish

Copy link

pkg-pr-new bot commented Oct 17, 2024

pnpm add https://pkg.pr.new/vitepress@4286

commit: 5cc5ead

@brc-dd
Copy link
Member

brc-dd commented Oct 17, 2024

Need someone to confirm this on Chrome on Windows 10 or 11 (who hasn't customized fonts in Chrome/Win settings) - what does this show:

  1. Open https://vitepress.dev/zh/
  2. Open devtools
  3. Select <body>
  4. Uncheck "font-family" in "Styles" tab:
    image
  5. Select any Chinese text
  6. Go to "Computed" tab in devtools
  7. Scroll down to "Rendered Fonts":
    image

@Jungzl
Copy link
Contributor Author

Jungzl commented Oct 18, 2024

online version:
image

local version:
image

  • UA: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: Windows 11

@brc-dd brc-dd merged commit 668e9f7 into vuejs:main Oct 18, 2024
11 checks passed
brc-dd added a commit that referenced this pull request Oct 18, 2024
these are already handled by `sans-serif`

PingFang SC is used on macOS
Noto Sans CJK is used on Ubuntu
Microsoft YaHei is used on Windows

follow up on #4286
@Jungzl Jungzl deleted the fix-theme branch October 23, 2024 09:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants